On Thu, Jul 7, 2011 at 10:48 AM, Zhu, Peter J <[email protected]> wrote: > > >> -----Original Message----- >> From: [email protected] >> [mailto:[email protected]] On Behalf Of Kok, Auke-jan H >> Sent: Thursday, July 07, 2011 10:03 AM >> To: Arjan van de Ven; Zheng, Wu >> Cc: [email protected]; [email protected] >> Subject: Re: [meego-packaging] [meego-commits] 22380: Changes to >> MeeGo:1.2:oss:Testing/fastinit >> >> On Thu, Jul 7, 2011 at 6:47 AM, Arjan van de Ven <[email protected]> >> wrote: >> > On 7/7/2011 12:43 AM, zhengwu wrote: >> >> >> >> ++++++ check-bluetoothd-config.patch (new) >> >> --- check-bluetoothd-config.patch >> >> +++ check-bluetoothd-config.patch >> >> +--- old/rc.d/rc.sysinit 2011-07-05 11:02:17.472666472 +0800 >> >> ++++ new/rc.d/rc.sysinit 2011-07-05 13:28:36.905728247 +0800 >> >> +@@ -327,6 +327,15 @@ >> >> + fi >> >> + >> >> + if [ -x "/usr/sbin/bluetoothd" ] ; then >> >> ++ if [ -e /etc/boardname ]; then >> >> ++ BOARDNAME_REVISION=`cat /etc/boardname` >> >> ++ BOARDNAME=`echo $BOARDNAME_REVISION | >> sed >> >> 's!_[a-zA-Z0-9]*$!!g'` >> >> ++ if [ -x >> /usr/bin/$BOARDNAME_REVISION_bluetooth ]; then >> >> >> ++ /usr/bin/${BOARDNAME_REVISION}_bluetoot >> h >> >> ++ elif [ -x /usr/bin/$BOARDNAME_bluetooth ]; then >> >> ++ /usr/bin/${BOARDNAME}_bluetooth >> >> ++ fi >> >> ++ fi >> >> + /usr/sbin/bluetoothd >> >> + fi >> >> >> > >> > >> > ewwwww? >> > >> > we have different bluetooth BINARIES for different boards? >> > seriously? >> >> I was gonna comment on the terrible shell code, but it's nothing >> compared to having multiple bluetoothd binaries >> > You should reference how sensorfw-boardname.patch is implemented. Use > different config rather than different binaries
I hope this SR got rejected... right? Auke _______________________________________________ MeeGo-packaging mailing list [email protected] http://lists.meego.com/listinfo/meego-packaging
