On Thu, 2011-07-07 at 10:51 -0700, Arjan van de Ven wrote:
> On 7/7/2011 10:42 AM, Srinivasa Ragavan wrote:
> > ++++ b/mail/daemon/e-mail-data-store.c
> > +@@ -171,8 +171,10 @@ handle_get_folder_info_cb (CamelStore *store,
> > CamelFolderInfo *info, gpointer da
> > + g_variant_builder_add (builder, "(sssuii)", "", "", "", 0, -1, -1);
> > +
> > + variant = g_variant_builder_end (builder);
> > ++ g_variant_ref (variant);
> > + g_variant_builder_unref (builder);
> > +
> > ++ micro(printf("%s\n", g_variant_print (variant, TRUE)));
> > + egdbus_store_ms_complete_get_folder_info (gfi_data->object,
> > gfi_data->invocation, variant);
> > + g_variant_unref (variant);
> > +
>
> trying to understand the patch... the rest of the patch has nicely
> paired ref/unref pairs, but I fail to find the unref for this added ref.
This was the original bug I fixed first. I assumed that
g_variant_builder_end returns reff'ed variant, but it returns a
floating. When I fixed it here, I fixed this in rest of the code, by
reff'ing and unreffing it.
-Srini
_______________________________________________
MeeGo-packaging mailing list
[email protected]
http://lists.meego.com/listinfo/meego-packaging
