On Fri, Jul 8, 2011 at 10:15 PM, Kok, Auke-jan H <[email protected]> wrote: > On Fri, Jul 8, 2011 at 10:12 AM, Marko Saukko <[email protected]> wrote: >> On Fri, Jul 8, 2011 at 7:53 PM, Ulf Hofemeier <[email protected]> >> wrote: >>> Hi, >>> I have made the following changes to cmake in project >>> MeeGo:1.2:oss:Testing. Please review and accept ASAP. >>> >>> Thank You, >>> Ulf Hofemeier >>> >>> [This message was auto-generated] >>> >>> --- >>> >>> Request #22537: >>> >>> submit: home:ulf:branches:MeeGo:1.2:oss:Testing/cmake(r3)(cleanup) -> >>> MeeGo:1.2:oss:Testing/cmake >>> >>> >>> Message: >>> * Fri Jul 08 2011 Ulf Hofemeier <[email protected]> - 2.8.3 >>> - Removed cmake utilities Windows build directory as this is not needed for >>> MeeGo BMC#20850 >>> >> >> Hi, >> >> one should NEVER change the upstream tar ball, but only create patches >> so people can see what changes needs to be ported if the upstream >> version is changed. Please reject this submission. > > In this case, it's entirely legitimate. The original dist tarball from > upstream contains some... very questionable files. > > Patching them away still means that they are present. The better > solution is to just shoot a hole in the tarball. > > We discussed this case with release engineering very cautiously, and > came to the conclusion that removing the content was the only right > solution. > > Auke >
Fair enough. It might be good to mention this better in the changelog and bug though as "Removed as not needed" doesn't tell the whole truth in this case and at least to me it sounds like a unnessessary change to upstream tar ball. Regards, Marko _______________________________________________ MeeGo-packaging mailing list [email protected] http://lists.meego.com/listinfo/meego-packaging
