Wasn't this patch already reviewed as bad news, by Anas?

http://lists.meego.com/pipermail/meego-packaging/2011-July/247816.html

<http://lists.meego.com/pipermail/meego-packaging/2011-July/247816.html>
/Carsten

2011/7/20 Zhang Qiang <[email protected]>

> Hi,
> I have made the following changes to deltarpm in project
> MeeGo:1.2:oss:Testing. Please review and accept ASAP.
>
> Thank You,
> Zhang Qiang
>
> [This message was auto-generated]
>
> ---
>
> Request #22935:
>
>  submit:
> home:xiaoqiang:branches:MeeGo:1.2:oss:Testing/deltarpm(r3)(cleanup) ->
> MeeGo:1.2:oss:Testing/deltarpm
>
>
> Message:
>    Add MeeGo-disable-md5.patch to fix BMC#14789.
>
> State:   new          2011-07-19T22:56:13 xiaoqiang
> Comment: None
>
>
>
> changes files:
> --------------
> --- deltarpm.changes
> +++ deltarpm.changes
> @@ -0,0 +1,3 @@
> +* Thu Jul 14 2011 Qiang Zhang <[email protected]> - 3.5
> +- Add MeeGo-disable-md5.patch to fix BMC#14789
> +
>
> new:
> ----
>  MeeGo-disable-md5.patch
>
> spec files:
> -----------
> --- deltarpm.spec
> +++ deltarpm.spec
> @@ -15,6 +15,7 @@
>  Source: %{name}-git-20090913.tar.bz2
>  # Build with system zlib
>  Patch0: deltarpm-system-zlib.patch
> +Patch1: MeeGo-disable-md5.patch
>  BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>
>  BuildRequires: bzip2-devel, xz-devel, rpm-devel, popt-devel
> @@ -55,7 +56,7 @@
>  %setup -q -n %{name}-git-20090913
>  # Build with system zlib
>  %patch0 -p1 -b .zlib
> -
> +%patch1 -p1
>  %build
>  %{__make} %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" \
>     bindir=%{_bindir} libdir=%{_libdir} mandir=%{_mandir} prefix=%{_prefix}
> \
>
> other changes:
> --------------
>
> ++++++ MeeGo-disable-md5.patch (new)
> --- MeeGo-disable-md5.patch
> +++ MeeGo-disable-md5.patch
> +diff -uNr deltarpm-git-20090913/applydeltarpm.c
> deltarpm-git-20090913.new/applydeltarpm.c
> +--- deltarpm-git-20090913/applydeltarpm.c      2009-09-13
> 22:22:40.000000000 +0800
> ++++ deltarpm-git-20090913.new/applydeltarpm.c  2011-07-14
> 10:46:14.586506584 +0800
> +@@ -1833,10 +1833,12 @@
> +           xfree(dsigh);
> +         }
> +     }
> ++#if 0
> +   else if (memcmp(wrmd5res, d.targetmd5, 16) != 0)
> +     {
> +       fprintf(stderr, "%s: md5 mismatch of result\n", deltarpm);
> +       exit(1);
> +     }
> ++#endif
> +   exit(0);
> + }
>
> _______________________________________________
> MeeGo-commits mailing list
> [email protected]
> http://lists.meego.com/listinfo/meego-commits
>
_______________________________________________
MeeGo-packaging mailing list
[email protected]
http://lists.meego.com/listinfo/meego-packaging

Reply via email to