On 7/24/2011 7:33 PM, xiaoweiye wrote:
new:
----
0.18.0-0.19.2.patch
why is this a version update and not a patch ?
spec files:
-----------
--- meego-app-camera.spec
+++ meego-app-camera.spec
@@ -7,14 +7,15 @@
Name: meego-app-camera
Summary: MeeGo Camera Application
-Version: 0.18.0
+Version: 0.19.2
Release: 1
Group: Applications/Multimedia
License: Apache 2.0
URL: http://www.meego.com
-Source0: %{name}-%{version}.tar.bz2
+Source0: %{name}-0.18.0.tar.bz2
Source1: meego-app-camera.desktop
Source100: meego-app-camera.yaml
+Patch0: 0.18.0-0.19.2.patch
even if you are trying to hide it as a patch, it's still a version update.
sneaky and evil...
+++ b/FlashButton.qml
++
++// RepeatButton {
++// id: up
++
++// anchors.horizontalCenter: parent.horizontalCenter
++// y: (trough.y / 2) - (height / 2)
++
++// source: "image://themedimage/images/camera/camera_icn_add_up"
++// activeSource: "image://themedimage/images/camera/camera_icn_add_dn"
++
++// onClicked: {
++// moveScrub (scrub.y - stepSize);
++// }
++
++// rotationAngle: slider.rotationAngle
++// rotationCounterClockwise: slider.rotationCounterClockwise
++// rotationAnimationDuration: slider.rotationAnimationDuration
++// }
how is this chunk related to fixing the bug mentioned in the changelog ?
++
+--- a/ZoomSlider.qml
++++ b/ZoomSlider.qml
+@@ -7,6 +7,7 @@
+ */
+
+ import QtQuick 1.0
++import MeeGo.Ux.Gestures 0.1
+
+ Item {
+ id: slider
+@@ -50,6 +51,36 @@ Item {
+ // anchors.fill: parent
+ }
+
++ GestureArea {
++ id: gestureArea
++ x: 0
++ y: trough.y
++ width: slider.width
++ height: trough.height
or this?
+
+UseAsNeeded: false
why do you need to block AsNeeded? Is your makefile THAT broken ?
really this should be rejected; there are many many more changes in this
submission than the changes file describes.... including a version update.
_______________________________________________
MeeGo-packaging mailing list
[email protected]
http://lists.meego.com/listinfo/meego-packaging
