On 7/27/2011 1:35 AM, Rudi wrote:
Hi,
The content of the spec file, layermanager.spec:
===================================================================
Name: layermanager
Version: 0.9.0
Release: 1%{?dist}
Summary: GENIVI Layer Manager
Vendor: BMW AG
Vendor shouldn't be there; any build system will wipe this anyway
#Group:
you do need a group though
License: Apache
#URL:
Source0: %{name}-%{version}.tar.gz
BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
and you really don't want to do this. Just remove the line please; we
have a default buildroot already set.
BuildRequires: libXdamage-devel
BuildRequires: libXcomposite-devel
BuildRequires: libX11-devel
please use "pkgconfig(...)" style build requires for these
BuildRequires: cmake
BuildRequires: mesa-libEGL-devel
BuildRequires: mesa-libGLESv2-devel
BuildRequires: dbus-devel
and these three.
%install
rm -rf $RPM_BUILD_ROOT
please don't do this; we give you an empty buildroot.
cd build
make install DESTDIR=$RPM_BUILD_ROOT
please consider using %makeinstall like macros for this; that way you
also get rid of static libraries etc
%post
/sbin/ldconfig
%postun
/sbin/ldconfig
this is not nice; it causes a ton of extra overhead each upgrade/install
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
is the correct form; that way RPM will bundle these up and run them only
once, and also doesn't have to spawn a shell just to run ldconfig
%clean
rm -rf $RPM_BUILD_ROOT
please don't do this; we do this for you.
%files
%defattr(-,root,root,-)
%doc
doc what??
%{_libdir}/layermanager/communicator
%{_libdir}/layermanager/renderer
%{_libdir}/libLayerManagerCommands.so
%{_libdir}/libilmClient.so
.so files need to go into the devel package; .so.1 etc should not be.
%{_bindir}/*
%files devel
%defattr(-,root,root,-)
%{_includedir}/layermanager
%{_includedir}/ilm
%{_libdir}/layermanager/static/libLayerManagerUtils.a
please don't package static libraries at all.
_______________________________________________
MeeGo-packaging mailing list
[email protected]
http://lists.meego.com/listinfo/meego-packaging
