On 7/27/2011 1:37 AM, Rudi wrote:

(same comments from layermanager also apply here)

The content of the spec file, dlt-daemon.spec:
===================================================================
Name:           dlt-daemon
Version:        2.2.0
Release:        1%{?dist}
Summary:        GENIVI DLT-daemon
Vendor:         BMW AG
Group:          System Environment/Base
License:        LGPLv2.1 with special exception
Source0:        %{name}-%{version}.tar.gz
BuildRoot:      %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

eg not this

%package devel
Summary:        %{name} - Diagnostic Log and Trace: Development files
Requires:       %{name} = %{version}-%{release}, pkgconfig

pkgconfig is an automatic dependency if you ship .pc files in your devel package (also I think you are overdoing the use of the %{name} macro here in the Summary)



%package initscript
Summary:        %{name} - Diagnostic Log and Trace: MeeGo Init Script
Requires:       %{name}

since we no longer support initscripts in MeeGo.. no sure if this makes sense



# Manually copy docs for now since unoconv is not available on meego
# which breaks ENABLE_BUILD_DOC
install -m 644 ../doc/GENIVI_Specification_DLT_Daemon.odt 
$RPM_BUILD_ROOT/usr/share/doc/
install -m 644 ../doc/GENIVI_Specification_DLT_Daemon.vsd 
$RPM_BUILD_ROOT/usr/share/doc/
install -m 644 ../doc/GENIVI_UserManual_DLT_Client.odt 
$RPM_BUILD_ROOT/usr/share/doc/
install -m 644 ../doc/GENIVI_UserManual_DLT_Daemon.odt 
$RPM_BUILD_ROOT/usr/share/doc/
install -m 644 ../doc/Message_Flow.odg $RPM_BUILD_ROOT/usr/share/doc/

%doc doc

in %files would have solved this properly... also because /usr/share/doc is not a valid location for package docs
(needs to be a properly named subdirectory, which %doc will do for you)


# Install init script
mkdir -p $RPM_BUILD_ROOT/etc/rc.d/init.d
mkdir -p $RPM_BUILD_ROOT/etc/rc.d/rc5.d
install -m 755 ../testscripts/dltdaemon $RPM_BUILD_ROOT/etc/rc.d/init.d
pushd $RPM_BUILD_ROOT/etc/rc.d/rc5.d
ln -s ../init.d/dltdaemon S50dltdaemon
popd

NOOOOOOO
this is not how you install an initscript (never mind that we don't support them anymore)... you MUST use chkconfig to register your initscript, and you should NEVER EVER make such symlinks in a package itself.



/usr/share/doc/dlt2/LICENSE.txt

that should be %doc


_______________________________________________
MeeGo-packaging mailing list
[email protected]
http://lists.meego.com/listinfo/meego-packaging

Reply via email to