On Wed, Jul 27, 2011 at 1:34 PM, Ausmus, James <[email protected]> wrote: > On Wed, Jul 27, 2011 at 1:31 PM, Karur Mohan, Prajwal > <[email protected]> wrote: >> I have reverted this sr in MeeGo testing. >> > > Why? You don't know yet if this is a bug or intended behavior - have > you checked the wireframes to see if this is *actually* a bug, or just > being misinterpreted as a bug?
this would have been solved with a COMMENT in the code, that explains the oddness of taking half the height. and then code review becomes possible. Most of this patch just says "fixes FOO" and then changes to the code. Really, you spend 20 minutes rebuilding and testing. Would it hurt to write one line of comment in the code explaining what the non-obvious change does? Auke _______________________________________________ MeeGo-packaging mailing list [email protected] http://lists.meego.com/listinfo/meego-packaging
