Hi Em Qui, 2011-07-28 às 11:36 -0700, Arjan van de Ven escreveu: > On 7/28/2011 11:34 AM, Gustavo Pichorim Boiko wrote: > > Hi Arjan > > > > Em Qui, 2011-07-28 às 11:26 -0700, Arjan van de Ven escreveu: > >> On 7/28/2011 11:05 AM, Gustavo Boiko wrote: > >>> -Subject: [PATCH 08/10] Fix notification missed for the first incoming > >>> chat > >>> +Subject: [PATCH 08/11] Fix notification missed for the first incoming > >>> chat > >> why are you touching all patches in this package instead of adding only > >> 2 for strictly the bugs you are fixing????? > >> > > I'm managing my changes in git, > > whatever your workflow is.. that's your problem ;-) > > > and generating patches as the fixes are > > merged into my branch. I thought it would be a good idea to keep the > > numbering consistent, but I can always just add the new ones without > > replacing the current ones. > > with a completely locked down branch... you really want to do the > absolute minimal > to fix bugs.. and get that reviewed. Randomly touching existing patches > (even if it's just the description not the rest) > really has no place in that; it takes away the "minimal" and also makes > reviews much harder than needed. > Please do not do that.
Sorry for that. I will just add the new patches from now on. Cheers Gustavo Boiko _______________________________________________ MeeGo-packaging mailing list [email protected] http://lists.meego.com/listinfo/meego-packaging
