Hi Kacper, I did look at your patch and have even been hacking it a little locally. I'm glad to see you still pushing it. It's long overdue, but here's my feedback if you're still interested.
There are two features which I wanted to add to your patch 1) blocking mode: When a tab is opened from dbus, it should block and return the exit status from the tab. This is the killer application of dbus imho since it makes it much more friendly to vc merge scripts (which currently have to rely on timestamp sniffing etc). This needs some work on the meld side to actually provide the exit status. 2) If there are multiple meld instances running, when the dbus instance exits, one of the other instances should take over. Otherwise you can have several melds none of which respond to dbus requests. Stephen. On Sat, Jun 28, 2008 at 4:41 PM, Kacper Wysocki <[EMAIL PROTECTED]> wrote: > On Fri, Jun 27, 2008 at 1:16 AM, Stephen Kennedy <[EMAIL PROTECTED]> wrote: >> Many thanks to all patch submitters. I've picked out the larger ones for >> mentions in the changelog but they're all appreciated. >> >> Encouragingly there have been more patches in the last few months >> than in the several years preceding. Long may it continue! > > I realize that the issue may now be smelly but what happened to the > dbus code to launch separate calls to meld in new tabs in the same > window [*]? Considering I've been pushing the patch for years now > without feedback I'm assuming there is something wrong with it and/or > meld is not such a patch-friendly project. I guess I get to keep my > own "fork" with dbus support. What gives? > > Cheers, > -Kacper > > [*] Description and patch at http://kacper.doesntexist.org/hacks/#meld > and bugtrack http://bugzilla.gnome.org/show_bug.cgi?id=453670 > -- > http://kacper.doesntexist.org > http://windows.dontexist.net > There is symmetry in chaos, and chaos in excessive order. > Though you may see heaven or hell, remember that it is your mind which > creates them. Avoid grasping the one or fleeing the other. > _______________________________________________ meld-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/meld-list
