2009/3/10 Stephen Kennedy <[email protected]>: >> One minor nitpick - the spacing in vcview.glade on hbox2 should be set >> to 6 (or 12?) (and HistoryFileEntry should probably have always been >> 6, not 4). >> >> Rather than post a diff of your diff, I've attached an updated version >> of your patch that works-for-me, and includes the above changes. > > This is a great feature. This patch works for me too, except for the same > warnings as Vincent. I see google has plenty of hits, but I didn't get to > the root cause. > > One minor nitpick about the spacing - shouldn't the browse... button be a > little closer to the entry since they're related and unrelated to the combo?
HIG-wise, spacings are supposed to be multiples of 6, so I originally set the hbox2 spacing (i.e., what ends up being the space between the browse and the combo) to 12, but reset it to 6 later because it looked a little odd. Setting it to 12 would give some nice visual separation. Alternatively, maybe set HistoryFileEntry's hbox spacing to 3 and leave hbox2 at 6? Not HIG-y, but at least visually consistent. Kai _______________________________________________ meld-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/meld-list
