2009/3/24 Vincent Legoll <[email protected]>: > I think vcview should use historyentry the same way as dirdiff & filediff, > by using its exposed API methods and not directly poking at its internals. > > This is a no-op fix that is orthogonal to other historyentry.py work > and I think it > should go in regardless of the other patches. > > Nothing is changed by that patch, the same code is executed, we just don't > open code historyfileentry behavior in vcview, we just use the provided API.
Looks good. However, with the change I just suggested for moving the history saving to happen on entry activation, the set filename here won't be saved into the history. Looking at it, I think that this (i.e., not saving) is the behaviour I'd expect, but I'm not certain. Kai _______________________________________________ meld-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/meld-list
