I've been thinking about a "stats settings" that effectively dumps
the settings struct.  It helps in those cases where someone is asking
questions and you want to know something about their config.

  It also helped to write tests for the -C and -b: arguments that got
messed up specifically (as pointed out by Clint Webb).  I was able to
write a simple startup test that verifies that -C properly sets the
CAS setting where we want it, and -b: properly sets the tcp backlog
where we want it.

  stats settings, documentation and tests are in my stats_settings
branch and visible here:

    
http://github.com/dustin/memcached/commit/0a83f5235d754543f602bc1aa670c49592bef541

  The option tests and fixes are here:

    
http://github.com/dustin/memcached/commit/d038aa38b8bfc4ae5abbe0079293082e5ec9073e

  In introducing these, I noticed that we are a bit hopeful in buffer
sizes when processing stats (as we need to do proper protocol-specific
termination).  Overall, I think the stats code may need a bit of work
to be safer, but this particular code is no worse.

  If the stats_setting is particularly unwelcome, I can at least
backport the bug fix (which is really just shifting a character
slightly).  I just wanted a test to go along with it.  :)

Reply via email to