On Mar 28, 8:02 pm, dormando <dorma...@rydia.net> wrote:
> Most of my own changes/can/should/will be pulled into the dev branch too. I've been using this as a review process of sorts. There's enough divergence in places that I have to understand it pretty well to move it over. :) I don't see anything that looks wrong yet. > The change I want the most scruitiny on is > 7208606e817dc401bcd3fde17038a3dfad604cab > ... which adds a really goofy hack to mitigate refcount leaks in the > system. I've not been able to nail down the last pesky bug or two which > causes those to happen, and this should prevent severe issues going > forward, and should stick around even if we find/fix all bugs. This makes sense to me. In dev, we have three such loops now so I'd kind of like to refactor it a bit to reuse the iterator and I'd kind of like to make the depth of each configurable. I kind of like that this makes me more resistant to the temptation of creating a command to increment the reference counter to make objects `sticky.' :)
