Gf, speaking about dirty code,

with regards to your project: http://code.google.com/p/mctop/
did you ever hear about switch command on php? you are using elseif
($f ==.. 10 times...
http://uk3.php.net/switch

also, line 102,103 ... 122,123 - why doing same math operation twice?

Eugene.

2009/4/22 gf <[email protected]>:
>
> Hi. It's really good idea, but your code is not good, IMHO.
> I've started the same project now..
> It will be released soon.
>
> On 22 апр, 23:34, ntang <[email protected]> wrote:
>> Hey all.  First post...
>>
>> We've been using memcached for a while, but we've never really done
>> much to monitor it past making sure the servers were up and running.
>> Anyways, we recently had some issues that looked like they might have
>> been related to memcached performance/ usage, and I figured it was
>> about time that we started taking a look at it.  We've added graphs
>> for various stats so we can track them over time, and added nagios
>> checks for the stats as well, but I also wanted a quick way to see the
>> immediate state of the cluster.
>>
>> So I wrote a little tool.  Hopefully people will find it useful.  It's
>> mostly configured by editing a config block up top, sue me.  It's
>> cheesy but works.  The first time you run it, you'll need (at a
>> minimum) to populate @servers.
>>
>> It's here:http://code.google.com/p/memcache-top/
>>
>> (In retrospect I should've named it memcached-top, but such is life.
>> I think people will be able to figure it out, and maybe if I put out
>> another 'release' (*cough*) I'll rename it.  ;)  )
>>
>> Thanks,
>> Nicholas

Reply via email to