I'm currently up in the mountains at our cabin without my computer. I'll look at the patches tomorrow when I get back home.

Trond

Sent from my iPhone

On 2. apr. 2010, at 07.31, KaiGai Kohei <[email protected]> wrote:

(2010/04/02 11:29), Dustin Sallings wrote:
Can you submit this as a series of independent changes, or perhaps a
just put up a repo somewhere?

We appreciate the work, but we'll need to break it up into consumable
chunks.

http://github.com/kaigai/memcached-selinux

I set up this repository.

The 'master' branch is a clone of the Trond's engine tree.

$ git clone git://github.com/kaigai/memcached-selinux.git
$ cd memcached-selinux
$ git diff origin/master origin/reworks_1
-> It adds get_socket_fd() server API to obtain socket file descriptor
   for the given cookie.

$ git diff origin/reworks_1 origin/reworks_2
-> It adds item_get_nkey() and item_get_ndata() engine APIs, to inject
   security attribute as a part of values by intermediation modules
   (such as bucket or selinux).

$ git diff origin/reworks_2 origin/reworks_3
-> It adds the 'features' field at engine_interface structure, to
   inform what features are supported by the loaded module.

$ git diff origin/reworks_3 origin/reworks_4
-> It replaces settings.engine.v1->xxx(...) invocations by wrapper
   functions.

# The 'selinux' branch is not available yet.

Thanks,

dustin sallings

On Apr 1, 2010 6:35 PM, "KaiGai Kohei" <[email protected]
<mailto:[email protected]>> wrote:

The attached patch reworked the engine framework based on the following
three ideas.


* A new server API to obtain socket file descriptor.

The get_socket_fd() server API allows engines to know properties of
connection socket.


* New APIs to retrieve length of key/data

The item_get_nkey() and item_get_ndata() engine APIs replaced direct
references to item->nkey and item->nbytes.


* Flags to show what features are provided with the engine module.

The 'features' field of ENGINE_HANDLE enables to inform the core
memcached (or intermediation module, like bucket) features of the
loaded engine module.

Any comments are welcome.

Thanks,


(2010/04/01 15:46), KaiGai Kohei wrote:
Hello,

As we discussed before, I focus on access con...



--
KaiGai Kohei <[email protected]>


--
To unsubscribe, reply using "remove me" as the subject.

Reply via email to