(2010/04/13 10:44), Trond Norbye wrote: > > On 1. apr. 2010, at 22.31, KaiGai Kohei wrote: > >> >> $ git diff origin/reworks_2 origin/reworks_3 >> -> It adds the 'features' field at engine_interface structure, to >> inform what features are supported by the loaded module. > > I couldn't see this branch anymore, but I pushed a proposal for this today.
Sorry, I already removed it... > I changed the signature for the existing "get_info" call to allow the engine > to return an arbitrary number of features it support. > If I remember correctly from your proposal you proposed this as a bitmask? > Since this isn't going to be part of any time/space-critical loops, I think > we shouldn't limit the design to a fixed number of features. Do you have a plan to provide guideline of the feature's signature? Is it informed via feature_info->feature? or need to parse description? > To make it even more "flexible" I decided to pass this as an array of > features, > each containing a value and a description. > > The next thing we need to do is to start "registering" different features :-) In your tree, default_engine.c and corresponding files are deployed at the top level directory... I think an engine module has an individual directory to store corresponding files, when we register different features. Thanks, -- KaiGai Kohei <[email protected]> -- To unsubscribe, reply using "remove me" as the subject.
