Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 263 by john.david.duncan: binary GET request does not handle ENGINE_TMPFAIL
http://code.google.com/p/memcached/issues/detail?id=263

In current 1.6 trees, if the engine responds to a binary GET request with ENGINE_TMPFAIL, memcached will print "Unknown error code: 13" and abort.

Suggested patch:

=== modified file 'daemon/memcached.c'
--- daemon/memcached.c  2011-09-20 05:13:01 +0000
+++ daemon/memcached.c  2012-04-05 23:58:46 +0000
@@ -1761,6 +1761,10 @@
     case ENGINE_NOT_MY_VBUCKET:
         write_bin_packet(c, PROTOCOL_BINARY_RESPONSE_NOT_MY_VBUCKET, 0);
         break;
+    case ENGINE_TMPFAIL:
+        write_bin_packet(c, PROTOCOL_BINARY_RESPONSE_ETMPFAIL, 0);
+        break;
+
     default:
         /* @todo add proper error handling! */
         settings.extensions.logger->log(EXTENSION_LOG_WARNING, c,




Reply via email to