Updates:
Status: Fixed
Comment #25 on issue 192 by [email protected]: Crash when sending
specially crafted packet
http://code.google.com/p/memcached/issues/detail?id=192
chtsanti: Could you please add tests for the specific issues your patch
addresses, and resubmit under a new bug report (or just a pull request on
github)?
I've merged sidhpurwala.huzaifa's change after some formatting fixes since
it came with a test and wasn't as nuts as some of the original patches. I'm
closing out this ticket, but I acknowledge that there are many things to
fix in the codebase.
I'll repeat again: Almost all of the security patches I've seen submitted
have been awful. They either change a harmless crash into an actual
segmentation fault, are pointless cargo-culted changes, or simply lack
tests.
It's really not that hard to do correctly. Channel some of that rage into
writing a quick test and understanding the code a bit better, please.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
---
You received this message because you are subscribed to the Google Groups "memcached" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
