Jacques Crocker <[email protected]> writes: > Hey Shalon. Thanks for reviewing the commit. I've fixed the errors you > mentioned, and cleaned up all the helper specs to spec out having id= > attributes set for unbound form elements when a name is present. > > Here is the commit: > http://github.com/merbjedi/merb/commit/96e3fde9e5c62973e560cbcd310981c25b640cc7
I'll try to review it this weekend, but I'm going to be out of town and will probably not have internet access, so I may not be able to get back to you. > > This seems to be handling id attributes properly on unbound form > controls. > > Also, can you suggest some additional text cases. I believe the specs > on form helpers are a bit too simple, and don't check complicated > cases like [] names, etc. The bound controls are well speced and > haven't been changed, however the unbound controls seem to be > suffering from a lack of specs. If you can come up with half a dozen > or so fairly complex unbound form examples, that would help out > greatly. You can use my github repo directly, or just post the > examples via gist or email. I'll take a look at them, and see what I can come up with, but to be honest, I'm not that familiar with what the form helpers _should_ do, which makes it difficult. Shalon Wood --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "merb" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/merb?hl=en -~----------~----~----~----~------~----~------~--~---
