So I just committed http://github.com/wycats/merb/commit/0e136a61b41167304a70f2433736d49b0693b32e
This means that both id and name are still generated but both now have 'form_submit' as value. I decided to not remove the id because it would break the existing spec linked in my previous post. On Thu, Oct 15, 2009 at 05:39, Martin Gamsjaeger <[email protected]> wrote: > Hmm ... updating merb-helpers to not produce the id involves skipping > the call to #update_unbound_controls. This however breaks > http://github.com/wycats/merb/blob/master/merb-helpers/spec/merb_helpers_form_spec.rb#L1292 > > I wonder if it's maybe better to just change the value to > submit_button and thus have it as id and name > > On Thu, Oct 15, 2009 at 03:57, Martin Gamsjaeger <[email protected]> wrote: >> I think it's probably feasible to ditch the id and rename the name >> value to "submit_button". >> >> I actually don't use the submit helper very often myself, i tend to >> just write html when I don't gain anything from using a helper. I do >> use ids on submit buttons for js/ajax stuff though. Mostly on pages >> with complex forms and/or more than one submit button. Since ids must >> be unique, using the current submit helper, I would need to explicitly >> pass the :id option anyway to produce valid xhtml. >> >> I really have no problem with making the id explicit as the option. If >> you need it, you probably shouldn't need to remember merb's naming >> conventions for that anyway. Also, it would generate valid xhtml in >> all cases. >> >> I have a patch for that already and I'll push it if there aren't any >> good reasons against it >> >> cheers >> snusnu >> >> On Wed, Oct 14, 2009 at 23:59, Tony Mann <[email protected]> wrote: >>> How about "submit_button"? >>> ..tony.. >>> >>> On Wed, Oct 14, 2009 at 2:45 PM, Yehuda Katz <[email protected]> wrote: >>>> >>>> Let's rename it. >>>> -- Yehuda >>>> >>>> On Wed, Oct 14, 2009 at 2:38 PM, Tony Mann <[email protected]> wrote: >>>>> >>>>> The name causes the same problems in jQuery. We would have to take them >>>>> both out. >>>>> ..tony.. >>>>> >>>>> On Tue, Oct 13, 2009 at 4:11 PM, Tony Collen <[email protected]> wrote: >>>>>> >>>>>> +1... if anything lose the id and leave the name, although I don't see >>>>>> the harm in ditching both. >>>>>> >>>>>> -Tony >>>>>> >>>>>> On Tue, Oct 13, 2009 at 6:03 PM, Tony Mann <[email protected]> >>>>>> wrote: >>>>>>> >>>>>>> By default, merb sets the name and ID of a submit button to "submit". >>>>>>> This causes the jQuery submit() method to fail in some cases. Now, this >>>>>>> is >>>>>>> clearly a bug in jQuery and not Merb, but setting the ID and name to >>>>>>> "submit" seems fairly pointless, and if it causes problems, why do it? I >>>>>>> recommend that we change merb-helper to use no default name and ID for >>>>>>> submit buttons. Thoughts? >>>>>>> ..tony.. >>>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> Yehuda Katz >>>> Developer | Engine Yard >>>> (ph) 718.877.1325 >>>> >>>> >>> >>> >>> >>> >>> >> > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "merb" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/merb?hl=en -~----------~----~----~----~------~----~------~--~---
