And now for my part of the conversation, to have things from IRC written
down :-)
Xavier Lange <[email protected]> wrote:
c) remove custom rack adapters
We should instead encourage config.ru usage with rackup or any other
server (unicorn, thin, etc). New servers come out all the time -- but
the unify factor is they all support rack.
That should, in fact, work right now in the active_support branch. I've
been playing with the config.ru generated for the "stack" application, and
it seems to work out of the box with "raw" rack and thin, so dropping the
custom adapters might be as easy as doing "git rm" and writing a few lines
in the changelog. Most of the Rack code is just there to deal with
deferrable codepaths, some works around issues in servers that are probably
resolved, and most of the work done in Merb::Rack::Application is error
handling and working around the fact that the Merb stack handles the
concept of a Rack response rather loosely. (IMO, the requirement of having
the body respond to #each is weird.)
e) Remove Merb's multipart parsing
Rack has multipart parsing support ripped out of IOWA -- we should use
that and make our code simpler.
My take is that dropping multipart support from the project scope might
cost us. From what I've seen, Rack's multipart handling is very much
focused on "binary blob" file uploads. This is fair, assuming the client is
a browser. However, in that process, some potentially vital information
like charsets get lost, and it also restricts the nature of incoming
requests.
When I started hacking on the multipart parser, I did that under the
premise to make it the point where incoming data, when possible, gets
properly earmarked with its charset or converted to UTF-8 (using the
encoding capabilities of Ruby 1.9). In my opinion, having a "UTF-8 clean"
side of the stack would be a boon, and allowing more complex requests than
just blob uploads might be interesting to people working with more complex
clients.
It would probably make sense to try and get that into Rack though :-)
--
You received this message because you are subscribed to the Google Groups
"merb" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/merb?hl=en.
