On 09/13/2016 12:52 PM, Pierre-Yves David wrote:
On 09/13/2016 12:47 PM, Pierre-Yves David wrote:
On 09/12/2016 03:13 PM, Augie Fackler wrote:
On Mon, Sep 12, 2016 at 02:36:19PM +0200, Maciej Fijalkowski wrote:
# HG changeset patch
# User Maciej Fijalkowski <fij...@gmail.com>
# Date 1473680234 -7200
# Mon Sep 12 13:37:14 2016 +0200
# Node ID a43b7edeb6d66afc5c4eab9e4c8bb35b94cbfa97
# Parent df05c43bd1e64f1620d0b2e502f4603c1e5a8341
lazymanifest: write a more efficient, pypy friendly version of
lazymanifest
Queued this. Looks like a clear improvement over what was there
before, even with the comments that have questions.
The lack of documentation makes it a bit hard to review but it seems
overall correct, The LazyManifestIter and LazyManifestIterEntries class
name are wrong as we don't use CamelCase (so lazymanifestiter and
lazymanifestiterentries). There is also a small error in the __getitem__
error message (says setitem)
However, tests do not pass with this patch so I've dropped it.
fijal, you can `hg pull
https://www.mercurial-scm.org/repo/users/marmoute/mercurial-dropped/ -r
bbc5c39158c8` get the version with the style and message version
highlighted above.
Gah, make this -r bbc5c39158c8 because I cannot copy paste properly :-/
--
Pierre-Yves David
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
