On 9/15/16 9:51 AM, Martin von Zweigbergk wrote:
On Wed, Sep 14, 2016 at 4:04 PM, Durham Goode <dur...@fb.com> wrote:
# HG changeset patch
# User Durham Goode <dur...@fb.com>
# Date 1473893509 25200
#      Wed Sep 14 15:51:49 2016 -0700
# Node ID 33a7df42b989c555972280f6b84e2fac38babf7b
# Parent  d41da1522f8efb5bf5aa75a51f0093b1129b6b5a
manifest: add manifestlog.get to obtain subdirectory instances

Previously manifestlog only allowed obtaining root level manifests. Future
patches will need direct access to subdirectory manifests as part of changegroup
creation,
Can I ask for this patch to be moved closer to those future patches so
it's easier to see how this is related and that the API makes sense
for those patches? I haven't checked to make sure, but the next
patches in this series didn't seem to depend on this patch. I can just
drop this patch in flight if you agree.
manifestlog.get() is actually necessary for patch #7 in this series, which requires access to the directory specific manifestctx to replace readshallowfast during changegroup creation.
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to