On 09/21/2016 11:09 PM, Augie Fackler wrote:

On Sep 21, 2016, at 17:05, Arun Kulshreshtha <kulsh...@fb.com> wrote:




On 9/21/16, 11:08 AM, "Augie Fackler" <r...@durin42.com> wrote:


On Sep 21, 2016, at 13:50, Pierre-Yves David <pierre-yves.da...@ens-lyon.org> 
wrote:



On 09/21/2016 07:31 PM, Augie Fackler wrote:
On Tue, Sep 20, 2016 at 01:35:22PM -0700, Arun Kulshreshtha wrote:
# HG changeset patch
# User Arun Kulshreshtha <kulsh...@fb.com>
# Date 1474318006 25200
#      Mon Sep 19 13:46:46 2016 -0700
# Node ID f157d9becfe724d624e0f3328febe58c5694d950
# Parent  0bb030bb1ce94c5514b671a3900ba207ebb19269
dispatch: make hg --profile wrap reposetup

This makes sense to me. Queued.

(I shiver a little bit at threadlocals, but what can you do? Sigh.)

Yuya raised multiples valid question when reviewing V2 and it is unclear they 
have all been addressed especially since the discussion where still going on in 
V2 after V3 was sent).
Did you checked the status of this series with Yuya ?

No, because I saw a v3 and discarded the entire v2 discussion, assuming v3 
resolved the things discussed in v2.

That assumption is probably a bit too quick. New contributors have a tendency to be very eager when it comes to send the next iteration, often before the previous batch is done discussing. In all case I usually find it useful to quickly checks the points made in the previous version by other reviewers. This help checking if they were all/properly fixed in the next iterations and unifying our pool of concerns.

Cheers,

--
Pierre-Yves David
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to