On 10/12/2016 11:23 PM, Martijn Pieters wrote:
On 12 Oct 2016, at 14:00, Yuya Nishihara <y...@tcha.org
<mailto:y...@tcha.org>> wrote:
FWIW, the current transformer will also rewrite open(f('foo')).

This then also applies to getattr(f('foo'), ...). We'll need to assert
that the 3rd token is a comma, I think.

Seems like the whole group of rewrite have a similar flaw. We should fix it in a follow up.

My current plan is to accept that changeset with an updated description incorporating Martijn explanation. I need to find some time to review its few descendants first because of a current flaw/limitation in our acceptance system.


Pierre-Yves David
Mercurial-devel mailing list

Reply via email to