On 10/13/2016 11:13 AM, Gregory Szorc wrote:
On Thu, Oct 13, 2016 at 11:09 AM, Martijn Pieters <m...@zopatista.com
> Nice refactor. While I haven't looked at the code in detail yet, does
check-code not complain about the use of underscore_function_names?
Apparently not! I did run the whole test suite, and ran it again
just now. Nested function names are locals and exempt from the rule
Should I resend with adjusted function names?
Unless I'm missing something obvious, you should.
And my guess is someone will patch the style checker to catch nested
function names :)
This makes a total of +2 ;-)
Mercurial-devel mailing list