On 10/09/2016 06:19 PM, Mads Kiilerich wrote:
On 10/09/2016 04:45 PM, Pierre-Yves David wrote:
On 10/09/2016 04:19 PM, Mads Kiilerich wrote:
diff --git a/hgext/eol.py b/hgext/eol.py
@@ -312,10 +312,15 @@ def reposetup(ui, repo):
self._eolmatch = util.never
+ oldeol = None
cachemtime = os.path.getmtime(self.join("eol.cache"))
This seems like it should live in the "cache/" directory. Any reason
not to ?
I don't know. I guess it predates the cache directory. I would probably
agree it now would be better if it lived there.
This patch is backwards compatible and doesn't change that. Changing the
location would be a separate independent change - and apparently trivial
and backwards compatible.
Ha yep. We should probably move the file in the cache directory in a
follow up patch.
I've pushed that patch as is. I've seen some scary (pre-existing) wlock
handling in the neighborhood of this patch, I'll send a follow up for that.
Mercurial-devel mailing list