Pierre-Yves David a écrit :
On 10/15/2016 02:25 PM, Yuya Nishihara wrote:
On Mon, 10 Oct 2016 14:33:17 +0200, Denis Laxalde wrote:
# HG changeset patch
# User Denis Laxalde <denis.laxa...@logilab.fr>
# Date 1475933106 -7200
#      Sat Oct 08 15:25:06 2016 +0200
# Node ID 6c916ce602f5c92c5a5a4de954629670b8c7ca8c
# Parent  dbcef8918bbdd8a64d9f79a37bcfa284a26f3a39
# EXP-Topic evolve-ui
templatekw: use a "?" to represent troubled changesets in graph

diff --git a/mercurial/templatekw.py b/mercurial/templatekw.py
--- a/mercurial/templatekw.py
+++ b/mercurial/templatekw.py
@@ -394,6 +394,8 @@ def showgraphnode(repo, ctx, **args):
         return '@'
     elif ctx.obsolete():
         return 'x'
+    elif ctx.troubled():
+        return '?'
     elif ctx.closesbranch():
         return '_'

Is this change an RFC or already discussed at the sprint?

This is an RFC, we had just a quick chat about it at the sprint.
Having a dedicated "char" for troubled changeset make senses, but I'm
not a fan of using "?". We should probably do a small brainstorming of
possible char at the beginning of the 4.1 cycle.

Yes, we just had an informal discussion, no real consensus. Waiting after the release is fine.

Denis Laxalde
Logilab         http://www.logilab.fr
Mercurial-devel mailing list

Reply via email to