* Yuya Nishihara on Monday, October 17, 2016 at 22:56:02 +0900
> On Mon, 17 Oct 2016 13:59:10 +0200, Christian Ebert wrote:
>> * Yuya Nishihara on Friday, September 09, 2016 at 21:50:31 +0900
>>> Maybe we'll have to handle _customcmp instead?
>>> 
>>> https://selenic.com/repo/hg/log?rev=bd19561b98d9%3A%3A7b038ec6c5fd
>> 
>> To be honest, I can't wrap my head around that. But do you simply mean
>> something like:
>> 
>> diff --git a/hgext/keyword.py b/hgext/keyword.py
>> --- a/hgext/keyword.py
>> +++ b/hgext/keyword.py
>> @@ -737,6 +737,8 @@ def reposetup(ui, repo):
>>             return ret
>> 
>>     def kwfilectx_cmp(orig, self, fctx):
>> +        if fctx._customcmp:
>> +            return fctx.comp(self)
> 
> Yeah, something like that. Per the backtrace in issue5364, fctx was an
> absentfilectx. In which case, basefilectx.cmp() is delegated to
> absentfilectx.cmp(). It makes sense to do the same here.

OK, I'll submit a patch. Feels a bit weird because the extension
has no way of knowing what a specific _customcmp does. Should be
OK for absentfilectx.cmp(), but there may be other _customcmp's
... I guess, that's a way to find out.

-- 
  Was hei├čt hier Dogma, ich bin Underdogma!
[ What the hell do you mean dogma, I am underdogma. ]
free movies       --->>> https://blacktrash.org/underdogma
http://itunes.apple.com/podcast/underdogma-movies/id363423596
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to