I will create new patches taking into account all the feedback so far.

The check-code.py tool shows that these errors exists already in hglib/*.py

hglib/client.py:574:
 >             raise ValueError('revision and node not found in hg output: %r' 
 > % out)
 line too long
hglib/client.py:879:
 >         if hasattr(patches, 'read') and hasattr(patches, 'readline'):
 hasattr(foo, bar) is broken, use util.safehasattr(foo, bar) instead
 hasattr(foo, bar) is broken, use util.safehasattr(foo, bar) instead
hglib/util.py:209:
 > def popen(args, env={}):
 don't use mutable default arguments

Barry

_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to