> On Dec 8, 2016, at 05:00, Kostia Balytskyi <kobal...@outlook.com> wrote: > > On 12/8/16 12:18 AM, David Soria Parra wrote: >> On Wed, Dec 07, 2016 at 10:23:08PM +0000, Kostia Balytskyi wrote: >>> On 12/7/16 9:51 PM, David Soria Parra wrote: >>>> # HG changeset patch >>>> # User David Soria Parra <davi...@fb.com> >>>> # Date 1481143876 28800 >>>> # Wed Dec 07 12:51:16 2016 -0800 >>>> # Node ID 109de539306c5bc49d38d6f1c802c4a8d092b485 >>>> # Parent be68e4436851b7e20f3b8cb34666418f5840dd66 >>>> convert: Create commits from revmap list if needed >>> This commit demonstrates the need to add some sort of comment to >>> self.revmap = {} in constructor. Otherwise, it's very confusing IMO. >> I honestly don't undersetand what is so confusing about it. It's a >> revmap and it seems straight forward to me that it's a dictionary >> that maps commits, at least thats what all revmaps in convert ever do. > The confusing (at least to me) part is what revmap maps commits to. > There's no example > of setrevmap usage, so it's unclear how it is used. Feel free to ignore > this if you think this is unreasonable though.
I'm also confused by the addition of setrevmap when it doesn't appear to be used by anything. Do you have follow-up work that this is leading to? pacem in terris / мир / शान्ति / سَلاَم / 平和 Kevin R. Bullock _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel