On 12/06/2016 10:53 PM, Jun Wu wrote:
Excerpts from Kostia Balytskyi's message of 2016-12-06 13:41:07 -0800:class CorruptedState(Exception): """error raised when a command is not able to read its state from file""" + +class MissingRequiredKeyInFileException(Exception): + """error raised when simple key-value file misses a required key"""I still think "CorruptedState" is better. It fits the use-case, is short and concise. 6-word exception sounds strange to me, partially because everything else in error.py is at most 4 words. If we have to use a new exception, maybe just "MissingRequiredKey", or just "KeyError".
I've not looked at any logic or any context for this, but "MissingRequiredKeyInFileException" is most certainly a TooLongNameToBeAccepted
See https://lwn.net/Articles/455265/ for details ;-) Cheers, -- Pierre-Yves David _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
