On Sat, 17 Dec 2016 16:40:12 -0800, Gregory Szorc wrote: > It's probably not worth worrying about just yet, but with Linux PID > namespaces, multiple processes may think they have the same PID, even if that > PID maps to different values inside the kernel. > > Mozilla has encountered problems with multiple hg processes running in > separate containers and PID namespaces acquiring the same lock from a shared > filesystem simultaneously because multiple hg processes share the same PID > and hostname in different "containers."
We wouldn't need to care much about that for chg, since there would be little benefit to mount /tmp as a shared filesystem (and we have a somewhat similar issue in the current code which uses flock.) The overall changes look good to me. _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel