> On Feb 5, 2017, at 20:29, Bryan O'Sullivan <b...@serpentine.com> wrote: > > > On Sun, Feb 5, 2017 at 1:44 AM, Yuya Nishihara <y...@tcha.org> wrote: > I like the direction of this patch, but this still involves a behavior > change. If PAGER variable is set but pager extension disabled, pager will > be started wrongly. > > I'm inclined to *not* add special code to see if the old pager extension has > been disabled. That's achievable by disabling the pager instead. This would > require a release note, of course (just in case anyone reads them).
I'm also not inclined to check for the old pager extension being disabled, but I don't think we can assume that people want hg output paged just because they have PAGER set in their environment. Most Unix-like environments seem to have it set by default nowadays. It's not quite clear to me, though: in this patch, is the pager is enabled when PAGER is set even if ui.pager is _not_ set? pacem in terris / мир / शान्ति / سَلاَم / 平和 Kevin R. Bullock _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
