On Mon, 20 Mar 2017 20:15:31 -0400, Augie Fackler wrote:
> On Mar 20, 2017 19:52, "Martin von Zweigbergk" <martinv...@google.com>
> wrote:
> On Sun, Mar 19, 2017 at 11:26 AM, Augie Fackler <r...@durin42.com> wrote:
> > + if pycompat.ispy3:
> > + ha = ha.encode('latin1')
>
> Every time I see "if pycompat.ispy3:", I feel like we should have
> extracted a function instead. Do others agree? What could this method
> be called? pycompat.latin1bytes()?
>
> Maybe. In this case a sha1 wrapper likely makes more sense.
or it could be node.hex(sha1(idbase).digest()).
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
