On Mon, Mar 20, 2017 at 11:24:45AM +0000, Ryan McElroy wrote: > On 3/20/17 8:22 AM, Yuya Nishihara wrote: > ># HG changeset patch > ># User Yuya Nishihara <y...@tcha.org> > ># Date 1489978255 -32400 > ># Mon Mar 20 11:50:55 2017 +0900 > ># Node ID db70a30dde5182e704b02b0e47a79d3ecfafdd49 > ># Parent cede8eaf55e2fe68434c273cfd066512b5ca112e > >graphlog: draw multiple edges towards null node (issue5440)
queued, thanks > > > >Before, edge (r, null) was processed only once by newparents. However what > >we really need is just stripping the edge (null, null). > > > [...] > I'd like to re-state for the record my wish that for subtle bugfixes like > this that we could split the fix into two patches: a patch that adds a test > exhibiting the broken behavior, and then the fix with the corrections to the > test. That would make it *so much easier* to review a patch like this. +1 > > For the curious (like me), the previous (broken) behavior was this (note the > missing /): > > @ 1 bar > | > | o 0 foo > | > o -1 > > The difference in the test output with this patch is thus: > > @ 1 bar > | > | o 0 foo > - | > + |/ > o -1 > > Overall, this change looks good to me. > _______________________________________________ > Mercurial-devel mailing list > Mercurial-devel@mercurial-scm.org > https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
