This patch looks like a pretty clear fix of a typo... should be straightforward to review. It's already been marked pre-reviewed.

However, I don't see mpm in the cc list? So adding him direct to:

~Ryan


On 3/28/17 9:08 PM, Kevin Bullock wrote:
Adding Matt to direct Cc:, who I think is still the sole maintainer of 
python-hglib (though that's still on our list to change, I think).

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock

On Mar 24, 2017, at 09:05, Long Vu <t.long...@gmail.com> wrote:

# HG changeset patch
# User Long Vu <l...@tlvu.ca>
# Date 1490322881 14400
#      Thu Mar 23 22:34:41 2017 -0400
# Node ID 820d7c1e470aaa11dad8f33e9161179a8115cef6
# Parent  ae38fb772613604dac7fcf63705e8a2a17ff50cd
hglib: fix hg clone --uncompressed option typo (issue5458)

Was getting error.CommandError
"hg clone: option --uncompresses not recognized".

diff --git a/hglib/__init__.py b/hglib/__init__.py
--- a/hglib/__init__.py
+++ b/hglib/__init__.py
@@ -28,7 +28,7 @@
           insecure=False, encoding=None, configs=None):
     args = util.cmdbuilder('clone', source, dest, noupdate=noupdate,
                            updaterev=updaterev, rev=rev, branch=branch,
-                           pull=pull, uncompresses=uncompressed,
+                           pull=pull, uncompressed=uncompressed,
                            e=ssh, remotecmd=remotecmd, insecure=insecure)

     args.insert(0, HGPATH)
diff --git a/tests/test-clone.py b/tests/test-clone.py
--- a/tests/test-clone.py
+++ b/tests/test-clone.py
@@ -11,3 +11,6 @@
         self.assertRaises(ValueError, cloned.log)
         cloned.open()
         self.assertEquals(self.client.log(), cloned.log())
+
+    def test_clone_uncompressed(self):
+        hglib.clone(b('.'), b('cloned'), uncompressed=True)


_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to