On 04/06/2017 08:18 PM, Jun Wu wrote:
Thanks for the clarification. My concern about performance is not writing the file, but calculating the content to be written. I'd like to see more clarification about whether and when this new code path triggers a full manifest read, since reading a flat manifest is painfully slow on a large repo.
They is a cache for the changeset → fnode mapping. And this cache is exchanged over the wire so I've not worried. Worst case we'll need a pass to strengthen the cache warming at commit time (as part of the "better use the cache before getting out of experimental"). So overall we should not triggers full manifest read.
Does this address your concerns? Cheers, -- Pierre-Yves David _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
