On Thu, 13 Jul 2017 22:11:11 +0200, Boris Feld wrote: > > > + self.audit(path, mode=mode, atomictemp=atomictemp) > > > > Is 'atomictemp' needed? I don't think 'atomictemp' can be generalized > > well to > > the other vfs operations. And atomictemp=True doesn't mean > > repo.lock/wlock > > is unnecessary. > > atomictemp wasn't technically necessary for this series, I included it > for completeness. If people starts wrapping pathauditor, adding > atomictemp later would results in breaking their wraps.
So we'll add e.g. 'src' of symlink() as well? IMHO, the interface of audit() and ward() in the original series is pretty basic. 'mode' might make some sense for all file operations, but 'atomictemp' wouldn't. > Do you want me to send a V4 to remove the atomictemp? Yeah, if that makes sense. _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
