yuja added inline comments. INLINE COMMENTS
> cmdutil.py:2307 > + matcher = revset.match(repo.ui, expr, repo=repo, > + order=revset.followorder) > revs = matcher(repo, revs) Perhaps these two shouldn't pass `ui` nor `repo`. They evaluate internal query. Passing `repo` means to take any valid old-style revisions ignoring the revset syntax. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D97 EMAIL PREFERENCES https://phab.mercurial-scm.org/settings/panel/emailpreferences/ To: indygreg, #hg-reviewers, durin42 Cc: yuja, durin42, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel