mitrandir accepted this revision.
mitrandir added inline comments.

INLINE COMMENTS

> phabricator.py:413
> +                drev = [d for d in drevs if int(d[r'id']) == drevid][0]
> +                newdesc = getdescfromdrev(drev)
> +                # Make sure commit message contain "Differential Revision"

I think it would be better to use differential.getcommitmessage for this. For 
example "reviewed by" field is a really nice thing to have in the commit 
message.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D122

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: quark, #hg-reviewers, mitrandir
Cc: mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to