lothiraldan added inline comments.

INLINE COMMENTS

> indygreg wrote in context.py:246-248
> This feels like it should be a set not a list.
> 
> Should this be changed as part of changing the API?

Semantically I agree, but the list has the nice property of being sorted.

If we change it to a set, I think we would be forced to sort it in order to 
have stable test outputs.

> indygreg wrote in exchange.py:694
> Why does this only print 1 instability?

I think it was easier to display a message when considering a single trouble. 
We could do better, but I'm not sure how displaying all troubles would interact 
with translation.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D238

To: lothiraldan, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to