yuja added inline comments.

INLINE COMMENTS

> obsolete.py:587
>  
> -        marker = (str(prec), tuple(succs), int(flag), metadata, date, 
> parents)
> +        prec = bytes(pycompat.bytestr(prec))
> +        marker = (prec, tuple(succs), int(flag), metadata, date, parents)

Why can't this be just `bytes(prec)` ?

I don't think `str(prec).encode('ascii')` is valid for binary node id.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D271

To: durin42, #hg-reviewers, quark
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to