indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
This method was added in
AFAICT it didn't do anything at
inception. If it did, there was no test coverage for it because
changing it to raise doesn't fail any tests at that revision.
later refactored all remote.batch() calls to
remote.iterbatch(). So if this was somehow used, it isn't called
any more because there are no calls to .batch() remaining in the
I suspect the original patch author got confused by the distinction
between the peer/remote interface and the largefiles store. The lf
store is a gateway to a peer instance. It exposes additional
lf-specific methods to execute against a peer. However, it is not
a peer and doesn't need to implement batch() because peer itself
diff --git a/hgext/largefiles/remotestore.py b/hgext/largefiles/remotestore.py
@@ -109,10 +109,6 @@
'from statlfile (%r)' % stat)
- def batch(self):
- '''Support for remote batching.'''
- return wireproto.remotebatch(self)
def _put(self, hash, fd):
'''Put file with the given hash in the remote store.'''
raise NotImplementedError('abstract method')
To: indygreg, #hg-reviewers
Mercurial-devel mailing list