durin42 added inline comments.

INLINE COMMENTS

> repository.py:29
> +    def url(self):
> +        """Returns a string representing this peer."""
> +

Nit: shouldn't this typically be a connection string with any credentials 
potentially redacted?

> repository.py:43
> +
> +        Most implementations will ``return self``.
> +        """

In what cases would a _basepeer not be a peer? What value does this part of the 
interface provide?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D332

To: indygreg, #hg-reviewers
Cc: durin42, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to