yuja added inline comments.

INLINE COMMENTS

> phabricator.py:280
>          diff = creatediff(ctx)
>          writediffproperties(ctx, diff)
>          transactions.append({'type': 'update', 'value': diff[r'phid']})

`writediffproperties()` is called twice. Perhaps one of them should be deleted.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D229

To: quark, #hg-reviewers, durin42
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to