yuja added inline comments. INLINE COMMENTS
> cmdutil.py:2557 > displayer.flush(ctx) > - edges = edgefn(type, char, lines, state, rev, parents) > - for type, char, lines, coldata in edges: > + for type, char, width, coldata in itertools.chain([firstedge], > edges): > graphmod.ascii(ui, state, type, char, lines, coldata) Just a nit. Is there any practical benefit to compute edges lazy? I think `edges` can be simply converted to a list. > hooper wrote in templatekw.py:768 > Can you explain why it should be renamed? I thought it should mirror > termwidth. They both return an integer for computations in templates. That's just a convention of templatekw. `termwidth` should be renamed too. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D360 To: hooper, #hg-reviewers Cc: yuja, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel