martinvonz added inline comments.

INLINE COMMENTS

> yuja wrote in templatekw.py:222
> > I'm not changing latesttagdistance (AFAIK), only the definition of 
> > latesttag.
> 
> Try `ptags = reversed(...)` and run tests. The largest `pdist` should be 
> selected
> so that `latesttagdistance` returns the longest path.

>> I'm not changing latesttagdistance (AFAIK), only the definition of latesttag.
> 
> Try ptags = reversed(...) and run tests. The largest pdist should be selected
>  so that latesttagdistance returns the longest path.

Ah, right, when the tag is in the common ancestor, we should choose the longest 
branch. Good catch.  See how you like this change.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D447

To: martinvonz, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to