yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> releasenotes.py:246
> +def _getadmonitionlist(ui, sections):
> + for section in sections._sections:
> + ui.write(_(str(section[0]) + ": " + section[1] + "\n"))
Perhaps this can be just `for section in sections` since
`releasenotessections` implements `__iter__`.
> releasenotes.py:247
> + for section in sections._sections:
> + ui.write(_(str(section[0]) + ": " + section[1] + "\n"))
> +
Delete `_()`, which is the marker for strings to be translated.
`"%s: %s\n" % ...` should be better for python 3 compatibility.
> releasenotes.py:523
> +
> + rev = opts.get('rev')
>
merge error?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D454
To: rishabhmadan96, #hg-reviewers, pulkit, yuja
Cc: yuja, pulkit, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
